Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Batch Predicitions #856

Merged
merged 8 commits into from
Jan 7, 2025
Merged

Batch Predicitions #856

merged 8 commits into from
Jan 7, 2025

Conversation

RohitP2005
Copy link
Contributor

I added a batch function mirroring the functionalities of predict_image,predict_tile and predict_file. I documented this behaviour inside a file called batch_predicitions.md since i was unsure where to document those. I also added test cases for the batch function, but commented them in the last of the file. Waiting for any corrections needed

@bw4sz
Copy link
Collaborator

bw4sz commented Dec 17, 2024

@RohitP2005 , you just have a really small error on the readthedocs index, not in the source code.

@bw4sz bw4sz mentioned this pull request Dec 17, 2024
Closed
@bw4sz
Copy link
Collaborator

bw4sz commented Dec 17, 2024

closes #849 when we finish this and merge.

@RohitP2005
Copy link
Contributor Author

@bw4sz yeah okay , thanks for the clarrifications. I will look into it

@RohitP2005
Copy link
Contributor Author

I made the necessary changes in the latest commit, Can my pull request be merged

bw4sz
bw4sz requested changes Jan 4, 2025
View reviewed changes
Copy link
Collaborator

@bw4sz bw4sz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments and questions, but the core case here is good, thanks for your support and time!

docs/user_guide/batch_predicitons.md Outdated Show resolved Hide resolved
.pre-commit-config.yaml Show resolved Hide resolved
src/deepforest/main.py Show resolved Hide resolved
tests/test_main.py Outdated Show resolved Hide resolved
tests/test_main.py Show resolved Hide resolved
@bw4sz bw4sz added API This tag is used for small improvements to the readability and usability of the python API. Awaiting author contribution Waiting on the issue author to do something before proceeding labels Jan 4, 2025
@bw4sz
Copy link
Collaborator

bw4sz commented Jan 6, 2025

The error

/home/runner/work/DeepForest/DeepForest/docs/user_guide/batch_predicitons.md:document isn't included in any toctree

can be solved by removing that file. I am adding a new 'prediction' page to the user guide that will cover this and the other methods. Once that is removed, the tests should pass and we can merge.

@github-actions github-actions bot removed the Awaiting author contribution Waiting on the issue author to do something before proceeding label Jan 6, 2025
@bw4sz bw4sz mentioned this pull request Jan 6, 2025
Merged
@RohitP2005
Copy link
Contributor Author

The error

/home/runner/work/DeepForest/DeepForest/docs/user_guide/batch_predicitons.md:document isn't included in any toctree

can be solved by removing that file. I am adding a new 'prediction' page to the user guide that will cover this and the other methods. Once that is removed, the tests should pass and we can merge.

Thnks for the classifications @bw4sz .
I will remove the file asap.

bw4sz
bw4sz approved these changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@bw4sz bw4sz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

@bw4sz bw4sz merged commit 2cf4198 into weecology:main Jan 7, 2025
4 checks passed
@RohitP2005
Copy link
Contributor Author

Anytime @bw4sz

@bw4sz bw4sz mentioned this pull request Jan 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bw4sz bw4sz bw4sz approved these changes

Assignees
No one assigned
Labels
API This tag is used for small improvements to the readability and usability of the python API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RohitP2005 @bw4sz